Fix 13933 #14487
Merged
Fix 13933 #14487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/libnative/io/file_win32.rs
Outdated
Contributor
There was a problem hiding this comment.
I think the convention would be for something like seek_inner.
Contributor
There was a problem hiding this comment.
(Or seek_common like below.)
The IO libraries casted self to mut so they can pass it to seek(SEEK_CUR, 0).
Fix this by introducing a private seek function that takes &self
- of course one should be careful with it if he lacks an
exclusive reference to self.
Contributor
Author
|
Improved indentation |
Member
directly use the internal pointer instead.
Contributor
Author
Contributor
Author
|
I will do Arena and Slice in separate commits |
bors
added a commit
that referenced
this pull request
May 29, 2014
Fix issue #13933 in a few files. A more complete fix would require core::raw::MutSlice.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…=Veykril fix: insert whitespace between text and pound Because `text#`, `text"..."`, and `text'...'` are [reserved syntax since Rust 2021][guide]. Note that the latter two are already handled correctly. Fixes rust-lang#14487 [guide]: https://doc.rust-lang.org/edition-guide/rust-2021/reserving-syntax.html
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 3, 2025
The `unnecessary_filter_map` and `unnecessary_find_map` lints were making partial suggestions, proposing to replace the whole expression by only the method name, or a subexpression which contained explicit placeholders. Since even `MaybeIncorrect` suggestions must generate code that compiles, this changes those lints to recommandation lints with no code suggestion. Fixes rust-lang#14486 changelog: [`unnecessary_find_map`, `unnecessary_filter_map`]: do not make suggestions that will not compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #13933 in a few files. A more complete fix would require core::raw::MutSlice.